On Fri, Oct 15, 2004 at 03:42:14PM +0200, submaster@rocklinux.org wrote:
> Open Patch: 2004101515421406752 [by blindcoder] + blindcoder
>
> Benjamin Schieder:
> splitapply shouldn't just silently fail

hmmm...

--snip--
+ echo "WARNING! No splitdesc_${n} function defined!"
+ echo "Here is an example:"
+ echo "splitdesc_dev() { desc_I=\"\$desc_I (development files)\"; }"
--snap--

it's not an error if the function is not defined. If the function isn't
defined that simply means that this split is not activated. E.g.:

if [ "$ROCKCFG_SPLIT_DOC" != 0 ]; then

        # only move doc/ to :doc, not man and info pages
        splitreg 60 doc '/share/doc/'
        splitdesc_doc() { desc_I="$desc_I (documentation)"; }

fi

so other scripts can register additional doc pattern without doing any harm
if the split isn't active at all.

It's ok to print a warning - but please don't put programming examples in
the build output. This would be too much..

What's about:

+ echo "Skipping package split: $p $1:$n $r (splitdesc_$n() undefined)"

yours,

 - clifford

--

 ____   ___   ____ _  __  _     _ www.rocklinux.org

| _ \ / _ \ / ___| |/ / | | (_)_ __ _ ___ __
| |_) | | | | | | ' / | | | | '_ \| | | \ \/ /
| _ <| |_| | |___| . \ | |___| | | | | |_| |> < Clifford Wolf
|_| \_\\___/ \____|_|\_\ |_____|_|_| |_|\__,_/_/\_\ www.clifford.at

Hardware /nm./: the part of the computer that you can kick.

_______________________________________________
rock-devel mailing list
rock-devel@rocklinux.org
http://www.rocklinux.net/mailman/listinfo/rock-devel