WebHosting Paid by #1Payday.Loans


   The ROCK Linux project has been discontinued in 2010. Here are the old data for the historical record!

[rock-linux] [PATCH] package selection (resend)

ROCK Mailing List Archives

Attachments
Entire message
+ (text/plain)
+   (text/html)
+ pkgsel.patch (application/octet-stream)
Author: 
Date:   
To: 
Subject: [rock-linux] [PATCH] package selection (resend)
Greetings,
Resending this patch because there was no response for some weeks.
I am currently building a desktop target with a minimal+xfree86 package
preselection template and custom package selection to include my ( not yet
published ) stf repository. I noticed that no stf package shows up in the
current package list, for the following reason:
In the files target/desktop/config.in, misc/pkgsel/minimal+xfree86.in and
others the sed expression:
/.*/ { s/^X /O /p; d; };
is used to disable packages, but the meaning is: "if a pattern (ie anything
that did not match one of the previous lines) is matched, substitute a
leading X with an O, and * ONLY IF * the substitution was made, print the new
pattern space, then delete it.
So if we apply it to an already disabled (O) package, this package does not
show up in the current package list and can never be selected for
compilation. Applying this filter twice (eg with the two .in files given
above) to an enabled (X) package has the same effect. The correct sed
expression should be:
/.*/ { s/^X /O / ; p; d; };
which always prints the matched pattern, regardless of any substitutions made.
I strongly opt for this behaviour because of the above mentioned reasons.
A patch modifying each occurrence of this sed expression is attached.

Keep on rocking,
Stefan Fiedler









Greetings,I am currently building a desktop
target with a minimal+xfree86 package preselection template and custom package
selection to include my ( not yet published ) stf repository. I noticed that no
stf package shows up in the current package list, for the following
reason:In the files target/desktop/config.in, misc/pkgsel/minimal+xfree86.in
and others the sed expression:/.*/ {
s/^X /O /p; d; };
is used to disable packages, but the meaning is:
"if a pattern (ie anything that did not match one of the previous lines) is
matched, substitute a leading X with an O, and * ONLY IF * the substitution was
made, print the new pattern space, then delete it. So if we apply it to an
already disabled (O) package, this package does not show up in the current
package list and can never be selected for compilation. Applying this filter
twice (eg with the two .in files given above) to an enabled (X) package has the
same effect. The correct sed expression should be:/.*/ { s/^X /O / ; p;
d; };which always prints the matched pattern, regardless of any
substitutions made.I strongly opt for this behaviour because of the above
mentioned reasons.A patch modifying each occurrence of this sed expression
is attached.
 
Keep on rocking,Stefan Fiedler